[HUDI-4144] Handle empty instants in Flink incremental input splits#5247
Closed
cuibo01 wants to merge 1 commit intoapache:masterfrom
Closed
[HUDI-4144] Handle empty instants in Flink incremental input splits#5247cuibo01 wants to merge 1 commit intoapache:masterfrom
cuibo01 wants to merge 1 commit intoapache:masterfrom
Conversation
…compaction timeline
Collaborator
codope
changed the title
danny0405
reviewed
May 24, 2022
| HoodieTableFileSystemView fsView = new HoodieTableFileSystemView(metaClient, commitTimeline, fileStatuses); | ||
| final String endInstant = instantToIssue.getTimestamp(); | ||
| final String endInstant = instantRange == null ? fsView.getLastInstant().get().getTimestamp() : instantToIssue.getTimestamp(); | ||
| final AtomicInteger cnt = new AtomicInteger(0); |
Contributor
There was a problem hiding this comment.
I'm confused, when instantRange == null is true, that means the user first time query from earliest, and we should read to the latest commit instant, which should be instantToIssue here.
Member
There was a problem hiding this comment.
Good point from Danny.
@cuibo01 Can you please explain that? Is it still a vlid scenario?
yihua
added
engine:flink
Contributor
|
@danny0405 is this still an issue for Flink? I'm revisiting table service-related PRs for the 0.15.0 release. |
Contributor
|
Can be closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the pull request
If issuedInstant is empty, the endInstant should not skip the compaction timeline. This PR fixes that behaviour.
Brief change log
(for example:)
Verify this pull request
(Please pick either of the following options)
This pull request is a trivial rework / code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Committer checklist
Has a corresponding JIRA in PR title & commit
Commit message is descriptive of the change
CI is green
Necessary doc changes done or have another open PR
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.