[WIP][MINOR] Add OperationField's enable to table config#5651
Closed
XuQianJin-Stars wants to merge 3 commits intoapache:masterfrom
Closed
[WIP][MINOR] Add OperationField's enable to table config#5651XuQianJin-Stars wants to merge 3 commits intoapache:masterfrom
XuQianJin-Stars wants to merge 3 commits intoapache:masterfrom
Conversation
XuQianJin-Stars
changed the title
XuQianJin-Stars
changed the title
xushiyan
reviewed
May 26, 2022
| public static final ConfigProperty<Boolean> ALLOW_OPERATION_METADATA_FIELD = ConfigProperty | ||
| .key("hoodie.allow.operation.metadata.field") | ||
| .defaultValue(false) | ||
| .sinceVersion("0.11.1") |
Member
There was a problem hiding this comment.
to users, this config has been there since 0.9.0, as the key did not change
Comment on lines
-459
to
-464
| public static final ConfigProperty<Boolean> ALLOW_OPERATION_METADATA_FIELD = ConfigProperty | ||
| .key("hoodie.allow.operation.metadata.field") | ||
| .defaultValue(false) | ||
| .sinceVersion("0.9.0") | ||
| .withDocumentation("Whether to include '_hoodie_operation' in the metadata fields. " | ||
| + "Once enabled, all the changes of a record are persisted to the delta log directly without merge"); |
Member
There was a problem hiding this comment.
@XuQianJin-Stars can you help me understand the main problem of the config staying in write config? Also, for user-facing config change, can we please file jira for tracking?
Contributor
|
@XuQianJin-Stars : can you follow up on the patch when you get a chance. |
Contributor
Author
closed, replace it #7598 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tips
What is the purpose of the pull request
(For example: This pull request adds quick-start document.)
Brief change log
(for example:)
Verify this pull request
(Please pick either of the following options)
This pull request is a trivial rework / code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Committer checklist
Has a corresponding JIRA in PR title & commit
Commit message is descriptive of the change
CI is green
Necessary doc changes done or have another open PR
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.