Skip to content

Comments

[HUDI-4191] docker failure#5756

Closed
victorxiang30 wants to merge 1 commit intoapache:masterfrom
victorxiang30:protobuf
Closed

[HUDI-4191] docker failure#5756
victorxiang30 wants to merge 1 commit intoapache:masterfrom
victorxiang30:protobuf

Conversation

@victorxiang30
Copy link

@victorxiang30 victorxiang30 commented Jun 6, 2022

What is the purpose of the pull request

Fix docker error on local machine. It requires '/' to recognise the volume path

Brief change log

(for example:)

  • Modify AnnotationLocation checkstyle rule in checkstyle.xml

Verify this pull request

(Please pick either of the following options)

This pull request is a trivial rework / code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end.
  • Added HoodieClientWriteTest to verify the change.
  • Manually verified the change by running a job locally.

Committer checklist

  • Has a corresponding JIRA in PR title & commit

  • Commit message is descriptive of the change

  • CI is green

  • Necessary doc changes done or have another open PR

  • For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

@hudi-bot
Copy link
Collaborator

hudi-bot commented Jun 6, 2022

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

@nsivabalan
Copy link
Contributor

@thanh-nguyen-dang: can you review this. you were working on docker fixes lately right.

@nsivabalan nsivabalan added the priority:medium Moderate impact; usability gaps label Jun 9, 2022
@nsivabalan
Copy link
Contributor

@victorxiang30 : Can you add description to the patch. and fill in the other entries in the template.

@nsivabalan
Copy link
Contributor

@victorxiang30 : gentle ping.

@victorxiang30
Copy link
Author

@nsivabalan added description

@bvaradar bvaradar self-assigned this Feb 18, 2023
@github-actions github-actions bot added the size:S PR with lines of changes in (10, 100] label Feb 26, 2024
@yihua
Copy link
Contributor

yihua commented Mar 7, 2024

@jonvex do you remember if this PR is needed to make docker demo work on Apple silicon? Or this has already been fixed so we can close it?

@jonvex
Copy link
Contributor

jonvex commented Mar 7, 2024

@yihua docker demo works for me, so I'm guessing this is not needed

@yihua
Copy link
Contributor

yihua commented Mar 9, 2024

Sg. Closing this PR. @victorxiang30 feel free to reopen the PR if you find it still needed to fix an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority:medium Moderate impact; usability gaps size:S PR with lines of changes in (10, 100]

Projects

Status: 🚧 Needs Repro
Status: ✅ Done
Status: Done

Development

Successfully merging this pull request may close these issues.

7 participants