[HUDI-4452] Include hudi-aws to hudi-spark-bundle to fix cloudwatch reporter issue#6183
[HUDI-4452] Include hudi-aws to hudi-spark-bundle to fix cloudwatch reporter issue#6183rahil-c wants to merge 1 commit intoapache:masterfrom
Conversation
|
@rahil-c Ideally, we need a way to completely decouple the two. Just because one class we need to pull in this dependency. Let's ensure that it is in provided scope so that other upstream libraries, where hudi-spark-bundle can be used, does not include hudi-aws. And on EMR the hudi-aws jar can be pre-installed in the classpath. wdyt? |
|
I am ok with landing this PR if we ensure hudi-aws is in provided scope. You can create a JIRA under HUDI-3529 for the decoupling task which can be tackled later on. |
|
Thanks @codope for taking a look, I think we will update our emr docs to specify customers to pass the the hudi-aws bundle to spark class path instead of adding it to spark bundle. |
Sounds good. Thanks @rahil-c |
Tips
What is the purpose of the pull request
When running hudi-spark-bundle on emr cluster, saw the following error when enabling CW
Enabled configs
error
it seems that we are not including the hudi-aws in hudi spark bundle however we do include hudi aws in the flink bundle by default. https://github.com/apache/hudi/blob/master/packaging/hudi-flink-bundle/pom.xml#L87
(For example: This pull request adds quick-start document.)
Brief change log
(for example:)
Verify this pull request
(Please pick either of the following options)
This pull request is a trivial rework / code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Committer checklist
Has a corresponding JIRA in PR title & commit
Commit message is descriptive of the change
CI is green
Necessary doc changes done or have another open PR
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.