[HUDI-4578] Reduce the scope and duration of holding checkpoint lock …#6337
Open
XuQianJin-Stars wants to merge 1 commit intoapache:masterfrom
Open
[HUDI-4578] Reduce the scope and duration of holding checkpoint lock …#6337XuQianJin-Stars wants to merge 1 commit intoapache:masterfrom
XuQianJin-Stars wants to merge 1 commit intoapache:masterfrom
Conversation
xiarixiaoyao
reviewed
Aug 9, 2022
|
|
||
| // only need to hold the checkpoint lock when emitting the splits | ||
| start = System.currentTimeMillis(); | ||
| synchronized (context.getCheckpointLock()) { |
Contributor
|
How much gains do we have after this change ? Guess the checkpoint lock would not block frequently ? |
Contributor
Author
To fundamentally solve the problem of stream read timeout and lock, it is necessary to optimize the number of |
XuQianJin-Stars
force-pushed
the
HUDI-4578
branch
from
535a749 to
3995309
Compare
yihua
added
priority:high
yihua
reviewed
Sep 13, 2024
Contributor
yihua
left a comment
yihua
left a comment
There was a problem hiding this comment.
@danny0405 is this still beneficial on Flink?
yihua
reviewed
Dec 13, 2025
Contributor
yihua
left a comment
yihua
left a comment
There was a problem hiding this comment.
@danny0405 @cshuo is this PR still needed after Hudi 1.1 uses async instant time generation in Flink?
Contributor
|
It is still valid issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Logs
Now the scope of the lock is too large.
Impact
Describe any public API or user-facing feature change or any performance impact.
Risk level: none | low | medium | high
Choose one. If medium or high, explain what verification was done to mitigate the risks.
Contributor's checklist