[HUDI-4636] Output preCombine&partition fields of delete records when changelog disabled#6429
Closed
flashJd wants to merge 1 commit intoapache:masterfrom
Closed
Conversation
4 tasks
…when changelog disabled
126dd3e to
8b3b995
Compare
Collaborator
4 tasks
Contributor
Can you explain why we need this then, do you want to write to another hudi table using these records ? |
Contributor
Author
@danny0405 we want to write this delete records to a warehouse or database, like apache phoenix, and want the precombine&partition field |
yihua
reviewed
Sep 13, 2024
Contributor
yihua
left a comment
There was a problem hiding this comment.
@danny0405 is this already fixed on Flink?
Contributor
|
We need more discussion on this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Logs
when changelog disabled, flink will output pk columns only,
https://github.com/apache/hudi/blob/master/hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/table/format/mor/MergeOnReadInputFormat.java#L364
We need the preCombine and partition fields also, so pull this request.
Impact
Describe any public API or user-facing feature change or any performance impact.
Risk level: none | low | medium | high
Choose one. If medium or high, explain what verification was done to mitigate the risks.
Contributor's checklist