[HUDI-4719] Add metrics config for flink#6497
Closed
wuwenchi wants to merge 1 commit intoapache:masterfrom
Closed
Conversation
Contributor
Author
|
@danny0405 Could you help review it? Thanks! |
wuwenchi
force-pushed
the
metrics_for_flink
branch
from
a3ffb50 to
7d1cf37
Compare
Collaborator
yihua
added
engine:flink
SteNicholas
reviewed
Sep 26, 2022
|
|
||
| private void updateCommitTimingMetrics(long commitEpochTimeInMs, long durationInMs, HoodieCommitMetadata metadata, | ||
| String actionType) { | ||
| String actionType) { |
Member
There was a problem hiding this comment.
Revert this change to keep the indent of the code style.
SteNicholas
reviewed
Sep 26, 2022
| // Metrics Options | ||
| // ------------------------------------------------------------------------ | ||
|
|
||
| public static final ConfigOption<Boolean> METRICS_ON = ConfigOptions |
Member
There was a problem hiding this comment.
Suggested change
| public static final ConfigOption<Boolean> METRICS_ON = ConfigOptions | |
| public static final ConfigOption<Boolean> TURN_METRICS_ON = ConfigOptions |
SteNicholas
reviewed
Sep 26, 2022
| .withDescription("Max delta commits for metadata table to trigger compaction, default 10"); | ||
|
|
||
| // ------------------------------------------------------------------------ | ||
| // Metrics Options |
Member
There was a problem hiding this comment.
Could metric options introduce METRICS_REPORTER_CLASS_NAME.key()?
Member
|
@wuwenchi, thanks for metric configs contribution. Could you please add certain tests to verify? cc @danny0405 |
yihua
reviewed
Sep 13, 2024
Contributor
yihua
left a comment
yihua
left a comment
There was a problem hiding this comment.
@danny0405 is this already supported?
Closed
Contributor
|
The metrics should work now since fix: #9637, close it as invalid. |
github-project-automation
bot
moved this from 🔖 Ready for review
to ✅ Done
in Hudi PR Support
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Logs
Describe context and summary for this change. Highlight if any code was copied.
Impact
Describe any public API or user-facing feature change or any performance impact.
Risk level: none | low | medium | high
Choose one. If medium or high, explain what verification was done to mitigate the risks.
Contributor's checklist