Skip to content

[DOC] [HUDI-4968] Update old config keys#6855

Merged
codope merged 1 commit intoapache:asf-sitefrom
voonhous:asf-flink-update
Nov 29, 2022
Merged

[DOC] [HUDI-4968] Update old config keys#6855
codope merged 1 commit intoapache:asf-sitefrom
voonhous:asf-flink-update

Conversation

@voonhous
Copy link
Member

@voonhous voonhous commented Oct 3, 2022

Change Logs

read.streaming.start-commit has been updated to read.start-commit for versions > 0.10.0. This commit updates lingering references to the read.streaming.start-commit config key to avoid confusion.

Impact

Describe any public API or user-facing feature change or any performance impact.

Risk level: none | low | medium | high

Choose one. If medium or high, explain what verification was done to mitigate the risks.

Documentation Update

Describe any necessary documentation update if there is any new feature, config, or user-facing change

  • The config description must be updated if new configs are added or the default value of the configs are changed
  • Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
    ticket number here and follow the instruction to make
    changes to the website.

Contributor's checklist

  • Read through contributor's guide
  • Change Logs and Impact were stated clearly
  • Adequate tests were added if applicable
  • CI passed

@voonhous voonhous changed the title [HUDI-4968] Update old config keys [DOC] [HUDI-4968] Update old config keys Oct 3, 2022
…disclaimer for `read.streaming.skip_compaction`
@nsivabalan nsivabalan added priority:high Significant impact; potential bugs priority:medium Moderate impact; usability gaps docs and removed priority:high Significant impact; potential bugs labels Oct 19, 2022
Copy link
Contributor

@bhasudha bhasudha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bhasudha
Copy link
Contributor

bhasudha commented Nov 2, 2022

@voonhous you have mentioned read.streaming.start-commit has been updated to read.start-commit for versions > 0.10.0 . I see the changes in versioned files starting 0.11.0. What about 0.10.1 ? If that should also change, please add changes for that version as well if needed.

Copy link
Contributor

@bhasudha bhasudha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a question on 0.10.1 to be addressed before merging otherwise LGTM

@codope codope merged commit a7c3d66 into apache:asf-site Nov 29, 2022
pintusoliya pushed a commit to pintusoliya/hudi that referenced this pull request Dec 22, 2022
… added disclaimer for `read.streaming.skip_compaction` (apache#6855)
@voonhous voonhous deleted the asf-flink-update branch May 15, 2023 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority:medium Moderate impact; usability gaps

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants