[HUDI-5162] Allow user specified start offset for streaming query#7138
Merged
YannByron merged 5 commits intoapache:masterfrom Nov 20, 2022
Merged
[HUDI-5162] Allow user specified start offset for streaming query#7138YannByron merged 5 commits intoapache:masterfrom
YannByron merged 5 commits intoapache:masterfrom
Conversation
Contributor
Author
|
@nsivabalan @YannByron can take a look now, the CI passed |
Contributor
Author
|
@hudi-bot run azure |
YannByron
reviewed
Nov 18, 2022
| case HoodieEarliestOffsetRangeLimit => | ||
| INIT_OFFSET | ||
| case HoodieLatestOffsetRangeLimit => | ||
| getLatestOffset.getOrElse(throw new HoodieException("Cannot fetch latest offset from table, " + |
Contributor
There was a problem hiding this comment.
can we use INIT_OFFSET when getLatestOffset is empty ? I mean getLatestOffset.getOrElse(INIT_OFFSET).
YannByron
reviewed
Nov 18, 2022
| package org.apache.hudi | ||
|
|
||
| import org.apache.hadoop.fs.Path | ||
|
|
Contributor
There was a problem hiding this comment.
please keep the import code style that separate the different package by a blank line.
Contributor
|
Nice work. Looks good, just leave two comments to solve. |
Contributor
Author
|
@hudi-bot run azure |
Contributor
Author
|
Hey @YannByron All comments are addressed. Please take a look. |
YannByron
approved these changes
Nov 20, 2022
satishkotha
pushed a commit
to satishkotha/incubator-hudi
that referenced
this pull request
Dec 12, 2022
fengjian428
pushed a commit
to fengjian428/hudi
that referenced
this pull request
Apr 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Logs
Add new configure:
hoodie.datasource.streaming.startOffsetto allow users to specify start offsetImpact
Should not affect users as it keeps the default behavior to fetch earliest offset if users don't set the configure.
Risk level (write none, low medium or high below)
low
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change
ticket number here and follow the instruction to make
changes to the website.
Contributor's checklist