[HUDI-5171] Ensure validateTableConfig also checks for partition path field value switch#7163
Merged
nsivabalan merged 3 commits intoapache:masterfrom Nov 10, 2022
Conversation
nsivabalan
approved these changes
Nov 9, 2022
Collaborator
satishkotha
pushed a commit
to satishkotha/incubator-hudi
that referenced
this pull request
Dec 12, 2022
… field value switch (apache#7163) Co-authored-by: Jonathan Vexler <=>
fengjian428
pushed a commit
to fengjian428/hudi
that referenced
this pull request
Apr 5, 2023
… field value switch (apache#7163) Co-authored-by: Jonathan Vexler <=>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Logs
Partition path field is not supposed to change so now there is validation to make sure of that.
I moved validateTableConfig to after validateKeyGeneratorConfig because some tests were failing due to the wrong error message showing up.
Also had to modify a test that was violating this validation
Impact
Now throws exception instead of letting user do something wrong.
Risk level (write none, low medium or high below)
low
Documentation Update
None needed
Contributor's checklist