[HUDI-5200] Clean up resources in hudi common UT#7190
Merged
xushiyan merged 1 commit intoapache:masterfrom Nov 13, 2022
Merged
Conversation
Contributor
Author
|
@hudi-bot run azure |
xushiyan
reviewed
Nov 13, 2022
| basePath = metaClient.getBasePath(); | ||
| } | ||
|
|
||
| protected void cleanMetaClient() { |
Member
There was a problem hiding this comment.
you could actually register this with @AfterEach ? so that subclasses won't have to call this
Contributor
Author
There was a problem hiding this comment.
you could actually register this with
@AfterEach? so that subclasses won't have to call this
There is no set up method provided in HoodieCommonTestHarness, the subclass controls the objects that need to be initialized, so the subclass controls the cleanup as well.
xushiyan
approved these changes
Nov 13, 2022
satishkotha
pushed a commit
to satishkotha/incubator-hudi
that referenced
this pull request
Dec 12, 2022
fengjian428
pushed a commit
to fengjian428/hudi
that referenced
this pull request
Apr 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Logs
In the current UT, some resources are not closed, this causes many local disk storage to be occupied
Impact
Clean up resources in hudi common UT
Risk level (write none, low medium or high below)
low
Documentation Update
none
Contributor's checklist