[MINOR] Fix locale specific NumberFormatException in testutils …#7215
Merged
codope merged 1 commit intoapache:masterfrom Dec 7, 2022
Merged
[MINOR] Fix locale specific NumberFormatException in testutils …#7215codope merged 1 commit intoapache:masterfrom
codope merged 1 commit intoapache:masterfrom
Conversation
nsivabalan
approved these changes
Dec 6, 2022
Contributor
|
@trushev : hey can you rebase w/ latest master please. |
…TestDataGenerator
Contributor
Author
Thank you, it's rebased |
Collaborator
nsivabalan
pushed a commit
that referenced
this pull request
Dec 13, 2022
…TestDataGenerator (#7215)
fengjian428
pushed a commit
to fengjian428/hudi
that referenced
this pull request
Apr 5, 2023
…TestDataGenerator (apache#7215)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…HoodieTestDataGenerator
Change Logs
String.format is locale specific. Example:
So default GERMAN locale leads to failure of
new BigDecimal("0,100000")with exceptionNumberFormatException.It is not convenient to develop when we have locale specific tests.
Impact
Fix
NumberFormatExceptionwhen default locale consists of comma as decimal separatorRisk level
None
Documentation Update
None
Contributor's checklist