Skip to content

[HUDI-5247] Clean up java client tests#7250

Merged
xushiyan merged 1 commit intoapache:masterfrom
xushiyan:HUDI-5247-cleanup-java-client-tests
Nov 21, 2022
Merged

[HUDI-5247] Clean up java client tests#7250
xushiyan merged 1 commit intoapache:masterfrom
xushiyan:HUDI-5247-cleanup-java-client-tests

Conversation

@xushiyan
Copy link
Member

@xushiyan xushiyan commented Nov 20, 2022

Change Logs

Test utils clean up: code improvements, remove redundant class

Impact

NA

Risk level

None

Documentation Update

NA

Contributor's checklist

  • Read through contributor's guide
  • Change Logs and Impact were stated clearly
  • Adequate tests were added if applicable
  • CI passed

*
* @throws IOException
*/
protected void cleanupDFS() throws IOException {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do not use HDFS for the tests

/**
* Base Class providing setup/cleanup and utility methods for testing Hoodie Client facing tests.
*/
public class HoodieJavaClientTestBase extends HoodieJavaClientTestHarness {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

redundant base class

@xushiyan xushiyan added the priority:medium Moderate impact; usability gaps label Nov 20, 2022
@hudi-bot
Copy link
Collaborator

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

@xushiyan xushiyan merged commit 926794a into apache:master Nov 21, 2022
@xushiyan xushiyan deleted the HUDI-5247-cleanup-java-client-tests branch November 21, 2022 02:42
satishkotha pushed a commit to satishkotha/incubator-hudi that referenced this pull request Dec 12, 2022
alexeykudinkin pushed a commit to onehouseinc/hudi that referenced this pull request Dec 14, 2022
alexeykudinkin pushed a commit to onehouseinc/hudi that referenced this pull request Dec 14, 2022
alexeykudinkin pushed a commit to onehouseinc/hudi that referenced this pull request Dec 14, 2022
alexeykudinkin pushed a commit to onehouseinc/hudi that referenced this pull request Dec 14, 2022
fengjian428 pushed a commit to fengjian428/hudi that referenced this pull request Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority:medium Moderate impact; usability gaps

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants