[HUDI-5252] ClusteringCommitSink supports to rollback clustering#7263
Merged
danny0405 merged 2 commits intoapache:masterfrom Nov 23, 2022
Merged
[HUDI-5252] ClusteringCommitSink supports to rollback clustering#7263danny0405 merged 2 commits intoapache:masterfrom
danny0405 merged 2 commits intoapache:masterfrom
Conversation
danny0405
reviewed
Nov 21, 2022
hudi-flink-datasource/hudi-flink/src/test/java/org/apache/hudi/utils/TestClusteringUtil.java
Show resolved
Hide resolved
SteNicholas
force-pushed
the
HUDI-5252
branch
from
c9cab08 to
1c8f9e4
Compare
danny0405
reviewed
Nov 22, 2022
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/util/ClusteringUtil.java
Outdated
Show resolved
Hide resolved
Collaborator
Member
Author
|
@danny0405, I have already addressed above comments. PTAL. |
danny0405
added
area:table-service
satishkotha
pushed a commit
to satishkotha/incubator-hudi
that referenced
this pull request
Dec 12, 2022
…che#7263) * [HUDI-5252] ClusteringCommitSink supports to rollback clustering
alexeykudinkin
pushed a commit
to onehouseinc/hudi
that referenced
this pull request
Dec 14, 2022
…che#7263) * [HUDI-5252] ClusteringCommitSink supports to rollback clustering
alexeykudinkin
pushed a commit
to onehouseinc/hudi
that referenced
this pull request
Dec 14, 2022
…che#7263) * [HUDI-5252] ClusteringCommitSink supports to rollback clustering
alexeykudinkin
pushed a commit
to onehouseinc/hudi
that referenced
this pull request
Dec 14, 2022
…che#7263) * [HUDI-5252] ClusteringCommitSink supports to rollback clustering
alexeykudinkin
pushed a commit
to onehouseinc/hudi
that referenced
this pull request
Dec 14, 2022
…che#7263) * [HUDI-5252] ClusteringCommitSink supports to rollback clustering
fengjian428
pushed a commit
to fengjian428/hudi
that referenced
this pull request
Apr 5, 2023
…che#7263) * [HUDI-5252] ClusteringCommitSink supports to rollback clustering
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Logs
When commit buffer has failed
ClusteringCommitEvent, theClusteringCommitSinkinvokes theCompactionUtil#rollbackCompactionto rollback clustering.ClusteringCommitSinkshould callClusteringUtil#rollbackClusteringto rollback clustering.Impact
Correct the way of rollback clustering to handle failure case in the
ClusteringCommitSink.Risk level (write none, low medium or high below)
If medium or high, explain what verification was done to mitigate the risks.
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change
ticket number here and follow the instruction to make
changes to the website.
Contributor's checklist