[HUDI-5285] Exclude *-site.xml files from jar packaging#7310
Merged
codope merged 1 commit intoapache:masterfrom Nov 29, 2022
Merged
[HUDI-5285] Exclude *-site.xml files from jar packaging#7310codope merged 1 commit intoapache:masterfrom
codope merged 1 commit intoapache:masterfrom
Conversation
Member
Author
|
@xushiyan Can you please review this patch? I think we can exclude the test resources (especially the properties files that conflict with user-provided resources) from every module. |
xushiyan
approved these changes
Nov 28, 2022
Member
sounds good. make sure test resources are used strictly by test code |
Collaborator
Member
Author
satishkotha
pushed a commit
that referenced
this pull request
Dec 13, 2022
fengjian428
pushed a commit
to fengjian428/hudi
that referenced
this pull request
Apr 5, 2023
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Logs
Exclude *-site.xml files from jar packaging. Fixes #7292
Impact
Minimal impact. Just excluding some test resources.
Risk level (write none, low medium or high below)
low
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change
ticket number here and follow the instruction to make
changes to the website.
Contributor's checklist