[HUDI-5340] Hudi supports Spark TVF#7400
Merged
XuQianJin-Stars merged 1 commit intoapache:masterfrom Dec 8, 2022
Merged
Conversation
Collaborator
Contributor
Author
|
@XuQianJin-Stars @leesf please take a look. cc @dongkelun @scxwhite |
leesf
reviewed
Dec 7, 2022
| case "read_optimized" => | ||
| assert(instants.isEmpty, "No expressions have to be provided in read_optimized mode.") | ||
| options += ("hoodie.datasource.query.type" -> "read_optimized") | ||
| case _ => |
Contributor
There was a problem hiding this comment.
would also need to add test to cover this case.
leesf
reviewed
Dec 7, 2022
| val instants = args.tail.map(_.eval().toString) | ||
| queryMode match { | ||
| case "read_optimized" => | ||
| assert(instants.isEmpty, "No expressions have to be provided in read_optimized mode.") |
Contributor
There was a problem hiding this comment.
the case instants is not empty should also be covered in test
scxwhite
reviewed
Dec 8, 2022
|
|
||
| private def parseOptions(args: Seq[Expression]): Map[String, String] = { | ||
| val options = mutable.Map.empty[String, String] | ||
| val queryMode = args.head.eval().toString |
Contributor
There was a problem hiding this comment.
For some immature ideas, the order of parameters must be fixed in the current way. Can we change the parameter to k=v later? After all, there are many read parameters in the hudi table.
XuQianJin-Stars
approved these changes
Dec 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Logs
Support Table-Valued Function.
Impact
none
Risk level (write none, low medium or high below)
none
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change
ticket number here and follow the instruction to make
changes to the website.
Contributor's checklist