Skip to content

[HUDI-5408][WIP] Fixing the way we rollback already completed commit in MDT, but failed in DT and re-attempted#7491

Closed
nsivabalan wants to merge 1 commit intoapache:masterfrom
nsivabalan:mdt_rollbackFailedWrites
Closed

[HUDI-5408][WIP] Fixing the way we rollback already completed commit in MDT, but failed in DT and re-attempted#7491
nsivabalan wants to merge 1 commit intoapache:masterfrom
nsivabalan:mdt_rollbackFailedWrites

Conversation

@nsivabalan
Copy link
Contributor

Change Logs

when compaction failed after completing in MDT but before completing in DT. and later when we re-attempt to apply the same compaction instant to MDT, we might miss to rollback any partially failed commit in MDT.

We need to ensure anytime we try to apply a commit to MDT, we rollback partially failed commit.
While working on the fix, realized that we are manually deleting the completed instant and proceed further. Its better if we trigger an actual rollback in MDT to keep it clean and avoid such manual interventions as maintaining such code might become tough in the long run.

Impact

Describe any public API or user-facing feature change or any performance impact.

Risk level (write none, low medium or high below)

If medium or high, explain what verification was done to mitigate the risks.

Documentation Update

Describe any necessary documentation update if there is any new feature, config, or user-facing change

  • The config description must be updated if new configs are added or the default value of the configs are changed
  • Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
    ticket number here and follow the instruction to make
    changes to the website.

Contributor's checklist

  • Read through contributor's guide
  • Change Logs and Impact were stated clearly
  • Adequate tests were added if applicable
  • CI passed

@nsivabalan
Copy link
Contributor Author

closing in favor of #7553

@nsivabalan nsivabalan closed this Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant