[HUDI-5479] Avoid to read the archived timeline each time for meta sync#7564
Closed
danny0405 wants to merge 1 commit intoapache:masterfrom
Closed
[HUDI-5479] Avoid to read the archived timeline each time for meta sync#7564danny0405 wants to merge 1 commit intoapache:masterfrom
danny0405 wants to merge 1 commit intoapache:masterfrom
Conversation
neverdizzy
added a commit
to neverdizzy/hudi
that referenced
this pull request
Dec 27, 2022
https://github.com/apache/hudi/pull/7564/files [HUDI-5479] Avoid to read the archived timeline each time for meta sync apache#7564
xushiyan
reviewed
Dec 27, 2022
| final HoodieDefaultTimeline timeline = metaClient.getActiveTimeline().isBeforeTimelineStarts(lastCommitTimeSynced.get()) | ||
| ? metaClient.getArchivedTimeline(lastCommitTimeSynced.get()).mergeTimeline(metaClient.getActiveTimeline()) | ||
| : metaClient.getActiveTimeline(); | ||
| return TimelineUtils.getWrittenPartitions(timeline.getCommitsTimeline().findInstantsAfter(lastCommitTimeSynced.get(), Integer.MAX_VALUE)); |
Member
There was a problem hiding this comment.
similar logic can be applied to getDroppedPartitionsSince()
Member
|
also pls rebase to get the CI to pass |
The user reports OOM error usually because of the archived timeline deserialization, which occurs for every meta sync after an instant is committed.
Contributor
Author
|
Close because there is another fix in: https://github.com/apache/hudi/pull/7561/files |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The user reports OOM error usually because of the archived timeline deserialization, which occurs for every meta sync after an instant is committed.
Change Logs
Avoid to dese the archived timeline each instant commit.
Impact
None
Risk level (write none, low medium or high below)
none
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change
ticket number here and follow the instruction to make
changes to the website.
Contributor's checklist