[HUDI-5504]Fix concurrency conflict when asyncCompaction is enabled#7609
Merged
Conversation
danny0405
reviewed
Jan 5, 2023
| if (asyncCompaction) { | ||
| synchronized (mutex) { | ||
| super.processLatencyMarker(latencyMarker); | ||
| } |
Contributor
There was a problem hiding this comment.
Can we just ignore the watermark and latency marker totally ? The compaction operators belongs to the sink ppeline, there is no need to propagate them to downstream.
Contributor
Author
There was a problem hiding this comment.
In my opinion, it will be more user-friendly to display through flink ui after delivery, and some specific functions may need to deliver this information. So i do not ignore the watermark and latency marker totally.
Contributor
Author
There was a problem hiding this comment.
now, i have ignored the watermark and latency marker totally. @danny0405
Contributor
Author
|
@hudi-bot re-run the last Azure build |
danny0405
reviewed
Jan 7, 2023
| package org.apache.hudi.sink.compact; | ||
|
|
||
| import org.apache.flink.streaming.runtime.streamrecord.LatencyMarker; | ||
| import org.apache.hudi.client.HoodieFlinkWriteClient; |
| @Override | ||
| public void processWatermark(Watermark mark) { | ||
| public void processWatermark(Watermark mark) throws Exception { | ||
| // no need to propagate the watermark |
| @Override | ||
| public void processLatencyMarker(LatencyMarker latencyMarker) | ||
| throws Exception { | ||
| // no need to propagate the latencyMarker |
Contributor
There was a problem hiding this comment.
No need to throw exception.
Contributor
There was a problem hiding this comment.
ClusteringOperator should also be fixed.
| () -> doCompaction(instantTime, compactionOperation, collector, reloadWriteConfig()), | ||
| (errMsg, t) -> collector.collect(new CompactionCommitEvent(instantTime, compactionOperation.getFileId(), taskID)), | ||
| (errMsg, t) -> { | ||
| collector.collect(new CompactionCommitEvent(instantTime, |
| instantTime, maxInstantTime, | ||
| writeClient.getHoodieTable().getTaskContextSupplier()); | ||
| collector.collect(new CompactionCommitEvent(instantTime, compactionOperation.getFileId(), writeStatuses, taskID)); | ||
| collector.collect(new CompactionCommitEvent(instantTime, compactionOperation.getFileId(), |
Contributor
Author
|
@hudi-bot run azure |
danny0405
approved these changes
Jan 9, 2023
danny0405
added
engine:flink
fengjian428
pushed a commit
to fengjian428/hudi
that referenced
this pull request
Jan 31, 2023
…latency marker (apache#7609) Co-authored-by: coder_wang <leiw5658@gmail.com>
nsivabalan
pushed a commit
to nsivabalan/hudi
that referenced
this pull request
Mar 22, 2023
…latency marker (apache#7609) Co-authored-by: coder_wang <leiw5658@gmail.com>
fengjian428
pushed a commit
to fengjian428/hudi
that referenced
this pull request
Apr 5, 2023
…latency marker (apache#7609) Co-authored-by: coder_wang <leiw5658@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Logs
Fix concurrency conflict when asyncCompaction is enabled
Impact
When asyncCompaction is enabled , CompactTaskMainThread and compactionThread will cause concurrency conflict when send watermark and compactionCommitEvent
Risk level (write none, low medium or high below)
high
Documentation Update
Contributor's checklist