[MINOR] Fix flaky tests in ITTestHoodieDataSource caused by unordered hashmap#7641
Merged
danny0405 merged 2 commits intoapache:masterfrom Jan 12, 2023
Merged
[MINOR] Fix flaky tests in ITTestHoodieDataSource caused by unordered hashmap#7641danny0405 merged 2 commits intoapache:masterfrom
danny0405 merged 2 commits intoapache:masterfrom
Conversation
danny0405
reviewed
Jan 11, 2023
|
|
||
| private Row row(Object... args) { | ||
| return Row.of(args); | ||
| } |
Contributor
There was a problem hiding this comment.
Can we move these utilities to TestData.java ?
Collaborator
danny0405
approved these changes
Jan 12, 2023
fengjian428
pushed a commit
to fengjian428/hudi
that referenced
this pull request
Jan 31, 2023
nsivabalan
pushed a commit
to nsivabalan/hudi
that referenced
this pull request
Mar 22, 2023
fengjian428
pushed a commit
to fengjian428/hudi
that referenced
this pull request
Apr 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes flaky tests in
ITTestHoodieDataSource.Tests sometimes are failed because they do the check
hashMap1.toString().equals(hashMap2.toString())while hashmap does not guarantee that the order of entries will remain constant over timeChange Logs
Replaced the check
hashMap1.toString().equals(hashMap2.toString())withhashMap1.equals(hashMap2)Impact
Fixed
testParquetComplexTypesandtestParquetComplexNestedRowTypesfailed with assertionwhere
{abc1=1, def1=3}!={def1=3, abc1=1}Risk level (write none, low medium or high below)
None
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change
ticket number here and follow the instruction to make
changes to the website.
Contributor's checklist