Skip to content

[HUDI-5530] Fix WARNING during compile#7647

Merged
danny0405 merged 2 commits intoapache:masterfrom
jackwener:warning
Sep 17, 2024
Merged

[HUDI-5530] Fix WARNING during compile#7647
danny0405 merged 2 commits intoapache:masterfrom
jackwener:warning

Conversation

@jackwener
Copy link
Member

@jackwener jackwener commented Jan 11, 2023 •
edited
Loading

Change Logs

Fix WARNING during compile.

  • remove redundant try
  • add explicit Throwable
  • remove useless cast

Impact

N/A

Risk level (write none, low medium or high below)

none

Documentation Update

N/A

Contributor's checklist

  • Read through contributor's guide
  • Change Logs and Impact were stated clearly
  • Adequate tests were added if applicable
  • CI passed

@jackwener
Copy link
Member Author

jackwener commented Jan 11, 2023

please use https://github.com/apache/hudi/pull/7647/files?diff=split&w=1 review.

It will ignore blank change.

@danny0405
Copy link
Contributor

danny0405 commented Jan 12, 2023

Assigned to you @alexeykudinkin , it's great if you can review this minor PR.

@jackwener
Copy link
Member Author

jackwener commented Jan 27, 2023

Would your mind to take a look this PR @yihua ? thanks❤️

@danny0405 danny0405 added the type:refactor Code refactoring and cleanup label Jan 31, 2023
@danny0405
Copy link
Contributor

danny0405 commented Jan 31, 2023

cc @alexeykudinkin if you have any time for this?

@nsivabalan
Copy link
Contributor

nsivabalan commented Feb 8, 2023

can u rebase w/ latest master. changes as such is good. if CI is green, we are good to land

@nsivabalan nsivabalan added the priority:medium Moderate impact; usability gaps label Feb 8, 2023
@jackwener
Copy link
Member Author

jackwener commented Feb 8, 2023

can u rebase w/ latest master. changes as such is good. if CI is green, we are good to land

Have done it, thanks you.

@github-actions github-actions bot added the size:M PR with lines of changes in (100, 300] label Feb 26, 2024
yihua
yihua approved these changes Sep 16, 2024
View reviewed changes
Copy link
Contributor

@yihua yihua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I helped rebase the PR.

@yihua
Copy link
Contributor

yihua commented Sep 16, 2024

@hudi-bot run azure

@yihua yihua changed the title [HUDI-5530] Fix WARNING during compile. [HUDI-5530] Fix WARNING during compile Sep 16, 2024
@hudi-bot
Copy link
Collaborator

hudi-bot commented Sep 17, 2024

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

@danny0405 danny0405 merged commit 75ab91c into apache:master Sep 17, 2024
nsivabalan pushed a commit to nsivabalan/hudi that referenced this pull request Sep 19, 2024
@jackwener @nsivabalan
[HUDI-5530] Fix WARNING during compile (apache#7647)
c13983d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yihua yihua yihua approved these changes

@danny0405 danny0405 danny0405 approved these changes

@alexeykudinkin alexeykudinkin Awaiting requested review from alexeykudinkin

Assignees

@alexeykudinkin alexeykudinkin

Labels

priority:medium Moderate impact; usability gaps size:M PR with lines of changes in (100, 300] type:refactor Code refactoring and cleanup

Projects

Hudi PR Support
Status: ✅ Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@jackwener @danny0405 @nsivabalan @yihua @hudi-bot @alexeykudinkin