[HUDI-5561] The preCombine method of PartialUpdateAvroPayload is not called#7675
Closed
xicm wants to merge 2 commits intoapache:masterfrom
Closed
[HUDI-5561] The preCombine method of PartialUpdateAvroPayload is not called#7675xicm wants to merge 2 commits intoapache:masterfrom
xicm wants to merge 2 commits intoapache:masterfrom
Conversation
danny0405
reviewed
Jan 16, 2023
Contributor
danny0405
left a comment
There was a problem hiding this comment.
A valid fix, can we add a test case for it
Collaborator
Contributor
Author
Done. :) |
Contributor
Author
|
@danny0405 The problem has been fix by #7759, we can close this pr. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Logs
The preCombine method we are using is
T preCombine(T oldValue);This method returns the newer record.For PartialUpdateAvroPayload we should return a new merged record, and this is implemented by
T preCombine(T oldValue, Schema schema, Properties properties).With this change, PartialUpdateAvroPayload will call
T preCombine(T oldValue, Schema schema, Properties properties), and other payloads still callT preCombine(T oldValue);Impact
Describe any public API or user-facing feature change or any performance impact.
none
Risk level (write none, low medium or high below)
none
If medium or high, explain what verification was done to mitigate the risks.
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change
ticket number here and follow the instruction to make
changes to the website.
Contributor's checklist