Skip to content

HUDI-162 : File System view must be built with correct timeline actions#775

Merged
bvaradar merged 1 commit intoapache:masterfrom
bvaradar:hudi_162
Jul 14, 2019
Merged

HUDI-162 : File System view must be built with correct timeline actions#775
bvaradar merged 1 commit intoapache:masterfrom
bvaradar:hudi_162

Conversation

@bvaradar
Copy link
Copy Markdown
Contributor

@bvaradar bvaradar commented Jul 2, 2019

No description provided.

@bvaradar bvaradar requested review from n3nash and vinothchandar July 2, 2019 01:20
n3nash
n3nash reviewed Jul 3, 2019
View reviewed changes
Comment thread hoodie-common/src/main/java/com/uber/hoodie/common/table/HoodieTimeline.java Outdated
Copy link
Copy Markdown
Contributor

@n3nash n3nash Jul 3, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is already a getCommitsAndCompactionTimeline in HoodieActiveTimeline, do we need this ?

Copy link
Copy Markdown
Member

@vinothchandar vinothchandar Jul 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Copy Markdown
Contributor Author

@bvaradar bvaradar Jul 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need similar method in HoodieTimeline interface. I have renamed the method to getCommitsAndCompactionTimeline so that they will be overridden by HoodieDefaultTimeline and HoodieActiveTImeline.

n3nash
n3nash requested changes Jul 3, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@n3nash n3nash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some comments

vinothchandar
vinothchandar reviewed Jul 9, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@vinothchandar vinothchandar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://issues.apache.org/jira/browse/HUDI-162 Can you add more context around the issue here

Comment thread hoodie-common/src/main/java/com/uber/hoodie/common/table/view/AbstractTableFileSystemView.java Outdated
Comment thread hoodie-common/src/main/java/com/uber/hoodie/common/table/view/AbstractTableFileSystemView.java Outdated
Copy link
Copy Markdown
Member

@vinothchandar vinothchandar Jul 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this needed? seems redundant with getTimeline()?

Copy link
Copy Markdown
Contributor Author

@bvaradar bvaradar Jul 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is needed to distinguish active timeline from commitsAndCompactionTimeline

Comment thread hoodie-common/src/main/java/com/uber/hoodie/common/table/HoodieTimeline.java Outdated
Copy link
Copy Markdown
Member

@vinothchandar vinothchandar Jul 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Comment thread hoodie-common/src/main/java/com/uber/hoodie/common/table/view/AbstractTableFileSystemView.java Outdated
@vinothchandar vinothchandar mentioned this pull request Jul 12, 2019
Closed
@bvaradar
Copy link
Copy Markdown
Contributor Author

bvaradar commented Jul 14, 2019

@n3nash @vinothchandar : Addressed/Replied-to review comments. Unit tests and automated hoodie-demo (manually triggered) ran fine. As discussed earlier, will go ahead merging this change.

@cdmikechen : I addressed the exception " java.lang.IllegalArgumentException: Can not create a Path from an empty string" as part of this PR. The pattern was found in few other places and I felt it is best handled together.

@bvaradar bvaradar merged commit ae3c02f into apache:master Jul 14, 2019
@bhasudha bhasudha mentioned this pull request Jul 17, 2019
Closed
@vinothchandar vinothchandar mentioned this pull request Jul 25, 2019
Closed
vamsikarnika added a commit to vamsikarnika/hudi that referenced this pull request Jun 28, 2024
@vamsikarnika
[ENG-10642][HUDI-7924] Capture Latency and Failure Metrics For Hive T…
ba4a793 
…able recreation (apache#775)

Co-authored-by: Vamsi <vamsi@Vamsis-MacBook-Pro.local>
Co-authored-by: Vamsi <vamsi@onehouse.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vinothchandar vinothchandar vinothchandar left review comments

@n3nash n3nash n3nash requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bvaradar @vinothchandar @n3nash