Skip to content

[MINOR] remove useless code.#7756

Merged
danny0405 merged 2 commits intoapache:masterfrom
jackwener:minor
Feb 8, 2023
Merged

[MINOR] remove useless code.#7756
danny0405 merged 2 commits intoapache:masterfrom
jackwener:minor

Conversation

@jackwener
Copy link
Member

Change Logs

remove useless code.

Impact

N/A

When I read the source code of HUDI, fix some simple problems.

Risk level (write none, low medium or high below)

none

Documentation Update

Describe any necessary documentation update if there is any new feature, config, or user-facing change

  • The config description must be updated if new configs are added or the default value of the configs are changed
  • Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
    ticket number here and follow the instruction to make
    changes to the website.

Contributor's checklist

  • Read through contributor's guide
  • Change Logs and Impact were stated clearly
  • Adequate tests were added if applicable
  • CI passed

@danny0405
Copy link
Contributor

Thanks for the contribution, can we check the test failure?

@jackwener
Copy link
Member Author

jackwener commented Jan 27, 2023

has resolve the Problem.
It's caused by that I remove boolean hasNext = hasNext();

I think code may exist problem.
Look like we didn't handle the condition that hasNext() return false.

    // TODO: when hasNext is false, we should not call next()
    boolean hasNext = hasNext();

I just read source code recently and I don't know about HUDI well. So, I don't ensure whether it exist problem.
So I don't add this TODO into this PR.

@hudi-bot
Copy link
Collaborator

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

@nsivabalan nsivabalan added priority:medium Moderate impact; usability gaps type:refactor Code refactoring and cleanup labels Feb 8, 2023
@danny0405 danny0405 merged commit 8329414 into apache:master Feb 8, 2023
fengjian428 pushed a commit to fengjian428/hudi that referenced this pull request Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority:medium Moderate impact; usability gaps type:refactor Code refactoring and cleanup

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants

Comments