Skip to content

Comments

[0.13.0 Only] Disable default Avro schema validation#7802

Merged
yihua merged 2 commits intoapache:release-0.13.0from
onehouseinc:ak/scn-vld-off
Feb 2, 2023
Merged

[0.13.0 Only] Disable default Avro schema validation#7802
yihua merged 2 commits intoapache:release-0.13.0from
onehouseinc:ak/scn-vld-off

Conversation

@alexeykudinkin
Copy link
Contributor

@alexeykudinkin alexeykudinkin commented Jan 31, 2023

Change Logs

NOTE: Instead of merging this PR into master, we should just merge this into our target RC branch, while keeping this enabled on master

As we discussed earlier today, disabling executing Avro schema validation by default.

Impact

No impact

Risk level (write none, low medium or high below)

Low

Documentation Update

N/A

Contributor's checklist

  • Read through contributor's guide
  • Change Logs and Impact were stated clearly
  • Adequate tests were added if applicable
  • CI passed

@alexeykudinkin alexeykudinkin requested a review from yihua January 31, 2023 05:59
@nsivabalan nsivabalan added the priority:blocker Production down; release blocker label Jan 31, 2023
@alexeykudinkin
Copy link
Contributor Author

val schemaValidationEnabledOpt = if (schemaEvolutionEnabled.toBoolean && schemaReconciliationEnabled) {
Some(false)
} else {
parameters.getOrDefault(HoodieWriteConfig.AVRO_SCHEMA_VALIDATE_ENABLE.key(), "true")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the reason we didn't see any tests failing -- we're overriding it to always be true (unless specified)

@hudi-bot
Copy link
Collaborator

hudi-bot commented Feb 1, 2023

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

@yihua yihua changed the title [DNM] Disable default Avro schema validation [0.13.0 Only] Disable default Avro schema validation Feb 2, 2023
@yihua yihua changed the base branch from master to release-0.13.0 February 2, 2023 17:58
@yihua yihua merged commit 3bcbdd0 into apache:release-0.13.0 Feb 2, 2023
CTTY pushed a commit to CTTY/hudi that referenced this pull request Apr 20, 2023
Disabling executing Avro schema validation by default.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority:blocker Production down; release blocker

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants