[HUDI-5774] Fix prometheus configs for metadata table and support metric labels#7933
Merged
codope merged 9 commits intoapache:masterfrom Feb 20, 2023
Merged
[HUDI-5774] Fix prometheus configs for metadata table and support metric labels#7933codope merged 9 commits intoapache:masterfrom
codope merged 9 commits intoapache:masterfrom
Conversation
lokeshj1703
changed the title
lokeshj1703
changed the title
lokeshj1703
changed the title
lokeshj1703
force-pushed
the
prometheus-labels
branch
2 times, most recently
from
6f36de2 to
4a9306d
Compare
codope
reviewed
Feb 16, 2023
...ient-common/src/main/java/org/apache/hudi/metrics/prometheus/PushGatewayMetricsReporter.java
Outdated
Show resolved
Hide resolved
| .withPushgatewayReportPeriodInSeconds(String.valueOf(writeConfig.getPushGatewayReportPeriodSeconds())) | ||
| .withPushgatewayHostName(writeConfig.getPushGatewayHost()) | ||
| .withPushgatewayPortNum(writeConfig.getPushGatewayPort()).build(); | ||
| builder.withProps(prometheusConfig.getProps()); |
lokeshj1703
force-pushed
the
prometheus-labels
branch
from
4a9306d to
d2c49dd
Compare
codope
approved these changes
Feb 20, 2023
Member
codope
left a comment
codope
left a comment
There was a problem hiding this comment.
Thanks for adding UT. Looks good to me now. Can you please rebase? We can land once the CI is green.
lokeshj1703
force-pushed
the
prometheus-labels
branch
from
d2c49dd to
bee3e29
Compare
fengjian428
pushed a commit
to fengjian428/hudi
that referenced
this pull request
Apr 5, 2023
…ric labels (apache#7933) Adds support for adding labels to prometheus metrics and fixes the prometheus configs used for metadata table.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Logs
Adds support for adding labels to prometheus metrics and fixes the prometheus configs used for metadata table.
Impact
NA
Risk level (write none, low medium or high below)
Low
Documentation Update
NA
Contributor's checklist