Skip to content

Comments

[HUDI-5804] Enable the flags in CommitsCommand that were suppressed by mistake#7963

Merged
bvaradar merged 2 commits intoapache:masterfrom
pramodbiligiri:pb-archived-commits
Mar 30, 2023
Merged

[HUDI-5804] Enable the flags in CommitsCommand that were suppressed by mistake#7963
bvaradar merged 2 commits intoapache:masterfrom
pramodbiligiri:pb-archived-commits

Conversation

@pramodbiligiri
Copy link
Contributor

@pramodbiligiri pramodbiligiri commented Feb 15, 2023

https://issues.apache.org/jira/browse/HUDI-5804

Change Logs

Fix typo in use of ShellOption annotation in CommitsCommand class. There were three places where the "--" prefix was missing.

Impact

Makes the following CLI flags actually available to be used by the user. Currently these were in the code but there was no way to invoke it:

  1. commit showpartitions --includeArchivedTimeline
  2. commit show_write_stats --includeArchivedTimeline
  3. commit showfiles --includeArchivedTimeline

Risk level (write none, low medium or high below)

Low. Exposes existing functionality that was getting suppressed by mistake.

Documentation Update

The shell option will show up automatically in the hudi-cli help.

Contributor's checklist

  • Read through contributor's guide
  • Change Logs and Impact were stated clearly
  • Adequate tests were added if applicable
  • CI passed

Copy link
Contributor

@bvaradar bvaradar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pramodbiligiri : Can you kindly rebase. Will merge once the tests pass after that.

@pramodbiligiri
Copy link
Contributor Author

@hudi-bot run azure

@hudi-bot
Copy link
Collaborator

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

@pramodbiligiri
Copy link
Contributor Author

@bvaradar Have merged latest master into this branch and build is passing.

@bvaradar bvaradar merged commit f4f329e into apache:master Mar 30, 2023
fengjian428 pushed a commit to fengjian428/hudi that referenced this pull request Apr 5, 2023
stayrascal pushed a commit to stayrascal/hudi that referenced this pull request Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants