[WIP][DO-NOT-MERGE] temp diff to investigate missed updates#8037
Closed
nsivabalan wants to merge 3 commits intoapache:masterfrom
Closed
[WIP][DO-NOT-MERGE] temp diff to investigate missed updates#8037nsivabalan wants to merge 3 commits intoapache:masterfrom
nsivabalan wants to merge 3 commits intoapache:masterfrom
Conversation
nsivabalan
commented
Feb 24, 2023
| return MarkerType.TIMELINE_SERVER_BASED.toString(); | ||
| } else { | ||
| LOG.warn("Embedded timeline server is disabled, fallback to use direct marker type for spark"); | ||
| if (!HoodieTableMetadata.isMetadataTable(this.writeConfig.getBasePath())) { |
Contributor
Author
There was a problem hiding this comment.
this is unrelated change.
| boolean success = writeClient.commit(instantTime, writeStatusRDD, Option.of(checkpointCommitMetadata), commitActionType, Collections.emptyMap()); | ||
| if (success) { | ||
| LOG.info("Commit " + instantTime + " successful!"); | ||
| LOG.warn("Commit " + instantTime + " successful! " + counter.incrementAndGet()); |
Contributor
Author
There was a problem hiding this comment.
to print out the number of commits succeeded w/ deltastreamer continuous mode.
| String.format("%s should be set to %s", INLINE_COMPACT.key(), cfg.isInlineCompactionEnabled())); | ||
| ValidationUtils.checkArgument(config.inlineClusteringEnabled() == clusteringConfig.isInlineClusteringEnabled(), | ||
| String.format("%s should be set to %s", INLINE_CLUSTERING.key(), clusteringConfig.isInlineClusteringEnabled())); | ||
| //ValidationUtils.checkArgument(config.inlineCompactionEnabled() == cfg.isInlineCompactionEnabled(), |
Contributor
Author
There was a problem hiding this comment.
by default inline compaction is not feasible w/ MDT. hence had to remove these conditions
This reverts commit 5cec02a.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Logs
Describe context and summary for this change. Highlight if any code was copied.
Impact
Describe any public API or user-facing feature change or any performance impact.
Risk level (write none, low medium or high below)
If medium or high, explain what verification was done to mitigate the risks.
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change
ticket number here and follow the instruction to make
changes to the website.
Contributor's checklist