[HUDI-5847] Add support for multiple metric reporters and metric labels#8041
Merged
codope merged 7 commits intoapache:masterfrom Mar 3, 2023
Merged
[HUDI-5847] Add support for multiple metric reporters and metric labels#8041codope merged 7 commits intoapache:masterfrom
codope merged 7 commits intoapache:masterfrom
Conversation
codope
reviewed
Feb 27, 2023
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metrics/Metrics.java
Outdated
Show resolved
Hide resolved
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metrics/Metrics.java
Outdated
Show resolved
Hide resolved
| reporterList.add(MetricsReporterFactory.createReporter(secondarySourceConfig, registry)); | ||
| } | ||
| } catch (IOException e) { | ||
| LOG.error("Failed to add MetricsExporters", e); |
Member
There was a problem hiding this comment.
let's remove this redundant log? the exception below already includes it.
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metrics/Metrics.java
Outdated
Show resolved
Hide resolved
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metrics/Metrics.java
Outdated
Show resolved
Hide resolved
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metrics/MetricUtils.java
Outdated
Show resolved
Hide resolved
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metrics/MetricUtils.java
Outdated
Show resolved
Hide resolved
...ent/hudi-client-common/src/main/java/org/apache/hudi/config/metrics/HoodieMetricsConfig.java
Outdated
Show resolved
Hide resolved
...client/hudi-client-common/src/main/java/org/apache/hudi/metrics/datadog/DatadogReporter.java
Outdated
Show resolved
Hide resolved
hudi-client/hudi-client-common/src/test/resources/datadog.properties
Outdated
Show resolved
Hide resolved
Contributor
|
can you take a look at #7934 and ensure there are no overlaps or do you need any coordination. |
Collaborator
Author
|
PR 7934 adds changes for supporting metric instances for different tables. This PR adds support for multiple reporters within a metric instance. |
Contributor
|
sg |
lokeshj1703
force-pushed
the
multipleReporters
branch
2 times, most recently
from
9dca0ad to
a8cdea9
Compare
codope
reviewed
Mar 2, 2023
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metrics/MetricUtils.java
Outdated
Show resolved
Hide resolved
lokeshj1703
force-pushed
the
multipleReporters
branch
from
d04edd5 to
b7c04d8
Compare
Contributor
|
CI is green |
codope
approved these changes
Mar 3, 2023
fengjian428
pushed a commit
to fengjian428/hudi
that referenced
this pull request
Apr 5, 2023
…ls (apache#8041) Add support for multiple metric reporters within a MetricRegistry. Further it also adds labels to metrics.
stayrascal
pushed a commit
to stayrascal/hudi
that referenced
this pull request
Apr 20, 2023
…ls (apache#8041) Add support for multiple metric reporters within a MetricRegistry. Further it also adds labels to metrics.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Logs
The PR aims to add support for multiple metric reporters within a Metric Registry. Further it also adds labels to metrics.
Impact
NA
Risk level (write none, low medium or high below)
low
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change
ticket number here and follow the instruction to make
changes to the website.
Contributor's checklist