[HUDI-5953][DNM] Handle duplicate records in HoodieCreateHandle#8228
Closed
codope wants to merge 1 commit intoapache:masterfrom
Closed
[HUDI-5953][DNM] Handle duplicate records in HoodieCreateHandle#8228codope wants to merge 1 commit intoapache:masterfrom
HoodieCreateHandle#8228codope wants to merge 1 commit intoapache:masterfrom
Conversation
HoodieCreateHandleHoodieCreateHandle
Member
Author
|
@hudi-bot run azure |
danny0405
requested changes
Mar 20, 2023
Contributor
danny0405
left a comment
There was a problem hiding this comment.
-1, don't think we should go in this direction, for HoodieCreateHandle, a premise is that the input data set should already be decuplicated, there are two impacts I could think of here:
- Introduces unnecessary overhead for many workflows, like bulk_insert, insert, compaction, clustering, etc.
- the cache of the keys could results in OOM exception, it is more safe the engine handles the deduplication job
Fix merge handle and dedupe conditional
cb172b5 to
1e2111d
Compare
HoodieCreateHandleHoodieCreateHandle
Collaborator
Member
Author
|
Closing it as the fix landed via cabcb2b |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Logs
Handle potential duplicates in
HoodieCreateHandle. It is already handled for compaction.DO NOT MERGE. Yet to cleanup tests.
Impact
No public API but critical change. Will affect inserts.
Risk level (write none, low medium or high below)
high
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change
ticket number here and follow the instruction to make
changes to the website.
Contributor's checklist