[HUDI-6083] Fix advanced config marking not taking effect in DataSourceOptions#8466
Merged
xushiyan merged 1 commit intoapache:masterfrom Apr 15, 2023
Conversation
xushiyan
approved these changes
Apr 15, 2023
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Logs
This PR fixes the advanced config marking not taking effect for three configs in
DataSourceOptions:Impact
This makes sure that all advanced configs do not show up in the "Basic Configurations" page.
Before the fix, the newly added test
TestDataSourceOptions.testAdvancedConfigsfailed. After the fix, the test succeeds now.Risk level
none
Documentation Update
N/A
Contributor's checklist