Skip to content

[HUDI-6083] Fix advanced config marking not taking effect in DataSourceOptions#8466

Merged
xushiyan merged 1 commit intoapache:masterfrom
yihua:HUDI-6083-fix-spark-datasource-advanced-configs
Apr 15, 2023
Merged

[HUDI-6083] Fix advanced config marking not taking effect in DataSourceOptions#8466
xushiyan merged 1 commit intoapache:masterfrom
yihua:HUDI-6083-fix-spark-datasource-advanced-configs

Conversation

@yihua
Copy link
Contributor

@yihua yihua commented Apr 14, 2023

Change Logs

This PR fixes the advanced config marking not taking effect for three configs in DataSourceOptions:

hoodie.schema.on.read.enable
hoodie.datasource.write.reconcile.schema
hoodie.datasource.write.drop.partition.columns

Impact

This makes sure that all advanced configs do not show up in the "Basic Configurations" page.

Before the fix, the newly added test TestDataSourceOptions.testAdvancedConfigs failed. After the fix, the test succeeds now.

Risk level

none

Documentation Update

N/A

Contributor's checklist

  • Read through contributor's guide
  • Change Logs and Impact were stated clearly
  • Adequate tests were added if applicable
  • CI passed

@hudi-bot
Copy link
Collaborator

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants