[HUDI-6095] Refactor the judgment condition of WorkloadProfile#8491
Merged
danny0405 merged 3 commits intoapache:masterfrom May 7, 2023
Merged
[HUDI-6095] Refactor the judgment condition of WorkloadProfile#8491danny0405 merged 3 commits intoapache:masterfrom
danny0405 merged 3 commits intoapache:masterfrom
Conversation
danny0405
reviewed
Apr 19, 2023
| protected boolean isWorkloadProfileNeeded() { | ||
| return true; | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
There is no use case for it to return false right?
Contributor
Author
There was a problem hiding this comment.
yes, it always returns true in all code.
danny0405
approved these changes
Apr 19, 2023
Contributor
danny0405
left a comment
danny0405
left a comment
There was a problem hiding this comment.
+1, guess this is a legacy code.
Contributor
|
@hudi-bot run azure |
1 similar comment
Contributor
|
@hudi-bot run azure |
huangxiaopingRD
force-pushed
the
HUDI-6095-workloadProfile
branch
from
a7e4751 to
f116e9c
Compare
huangxiaopingRD
force-pushed
the
HUDI-6095-workloadProfile
branch
from
3305fe5 to
e14ff9c
Compare
Contributor
Author
|
gently ping @danny0405 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Logs
Remove the
isWorkloadProfileNeededwhich is always returntrueImpact
No
Risk level (write none, low medium or high below)
None
Documentation Update
Contributor's checklist