[HUDI-6189] Reuse the timeline supplied in predefined variable or parameter#8664
Merged
danny0405 merged 1 commit intoapache:masterfrom May 10, 2023
Merged
Conversation
danny0405
reviewed
May 8, 2023
| return (HoodieTableFileSystemView) ReflectionUtils.loadClass(HOODIE_METASERVER_FILE_SYSTEM_VIEW_CLASS, | ||
| new Class<?>[] {HoodieTableMetaClient.class, HoodieTimeline.class, HoodieMetaserverConfig.class}, | ||
| metaClient, metaClient.getActiveTimeline().getCommitsTimeline().filterCompletedInstants(), metaClient.getMetaserverConfig()); | ||
| metaClient, timeline, metaClient.getMetaserverConfig()); |
Contributor
There was a problem hiding this comment.
This line exclude the compaction instants before, does it have regression?
Contributor
Author
There was a problem hiding this comment.
I review the Git commit history and find when instantiating HoodieMetadataFileSystemView, compaction instants were initially excluded. Later, in HUDI-3692, this issue was fixed by using the timeline that includes compaction instants.
So I think when initializing HoodieMetaserverFileSystemView, compaction instants should also be included to ensure the correctness of asynchronous compaction.
Collaborator
danny0405
added
type:refactor
danny0405
approved these changes
May 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Logs
Reuse the
timelinesupplied in predefined variable or parameterDescribe context and summary for this change. Highlight if any code was copied.
Impact
Describe any public API or user-facing feature change or any performance impact.
Risk level (write none, low medium or high below)
none
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change
ticket number here and follow the instruction to make
changes to the website.
Contributor's checklist