[HUDI-6214] Enabling compaction by default for batch writes with MOR table#8718
Merged
codope merged 3 commits intoapache:masterfrom Aug 14, 2023
Merged
[HUDI-6214] Enabling compaction by default for batch writes with MOR table#8718codope merged 3 commits intoapache:masterfrom
codope merged 3 commits intoapache:masterfrom
Conversation
nsivabalan
changed the title
nsivabalan
added
release-0.14.0
priority:critical
nsivabalan
added
priority:blocker
codope
reviewed
Jul 31, 2023
Member
codope
left a comment
codope
left a comment
There was a problem hiding this comment.
LGTM with some minor comments. Can you please rebase?
...-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieStreamingSink.scala
Show resolved
Hide resolved
...spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieSparkSqlWriter.scala
Outdated
Show resolved
Hide resolved
codope
force-pushed
the
enableCompactionMor
branch
from
27ae6fc to
e15a030
Compare
codope
approved these changes
Aug 4, 2023
codope
force-pushed
the
enableCompactionMor
branch
from
e15a030 to
52129fa
Compare
nsivabalan
added
priority:critical
codope
force-pushed
the
enableCompactionMor
branch
from
52129fa to
76f2bd5
Compare
codope
force-pushed
the
enableCompactionMor
branch
from
76f2bd5 to
e43cede
Compare
Member
|
@hudi-bot run azure |
prashantwason
pushed a commit
that referenced
this pull request
Aug 18, 2023
…table (#8718) Support better out-of-box user experience. If a user does not explicitly enable inline compaction w/ spark-datasource or spark-sql writes, inline compaction will be enabled. If user explicitly overwrites and disables, no overrides will happen. --------- Co-authored-by: Sagar Sumit <sagarsumit09@gmail.com>
4 tasks
leosanqing
pushed a commit
to leosanqing/hudi
that referenced
this pull request
Sep 13, 2023
…table (apache#8718) Support better out-of-box user experience. If a user does not explicitly enable inline compaction w/ spark-datasource or spark-sql writes, inline compaction will be enabled. If user explicitly overwrites and disables, no overrides will happen. --------- Co-authored-by: Sagar Sumit <sagarsumit09@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Logs
By default inline compaction is disabled for batch writes (spark datasource writes and soark-sql writes). But from a user exp standpoint, its better to enable it by default. So, if a user does not explicitly enable inline compaction w/ spark-datasource or spark-sql writes, inline compaction will be enabled. If user explicitly overwrites and disables, no overrides will happen.
Impact
Improves out of the box user experience.
Risk level (write none, low medium or high below)
low
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change
ticket number here and follow the instruction to make
changes to the website.
Contributor's checklist