[HUDI-6233] Fix table client conf in AlterTableCommand#8747
Merged
danny0405 merged 2 commits intoapache:masterfrom May 19, 2023
Merged
[HUDI-6233] Fix table client conf in AlterTableCommand#8747danny0405 merged 2 commits intoapache:masterfrom
danny0405 merged 2 commits intoapache:masterfrom
Conversation
danny0405
reviewed
May 18, 2023
| TABLE_TYPE.key -> TABLE_TYPE.defaultValue, | ||
| PRECOMBINE_FIELD.key -> PRECOMBINE_FIELD.defaultValue, | ||
| HoodieWriteConfig.WRITE_PAYLOAD_CLASS_NAME.key -> HoodieWriteConfig.DEFAULT_WRITE_PAYLOAD_CLASS, | ||
| INSERT_DROP_DUPS.key -> INSERT_DROP_DUPS.defaultValue, |
Contributor
There was a problem hiding this comment.
We may also need to fix the datasource options to sql options mappings: #8710
Collaborator
danny0405
reviewed
May 19, 2023
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/TestAlterTable.scala
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Logs
Use
HoodieWriterUtils.parametersWithWriteDefaultsto create conf inAlterTableCommand, which is more universal and includes global props.Impact
Fix table client conf in AlterTableCommand
Risk level (write none, low medium or high below)
low
Documentation Update
now
Contributor's checklist