[HUDI-6236] write hive_style_partitioning_enable to table config in D…

[voonhous]

…eltaStreamer entrypoints

Change Logs

In Hudi 0.10.X, Hudi assumes that hoodie table properties contains the hoodie.datasource.write.hive_style_partitioning configuration value.

As such hoodie.properties should contain this config for all Hudi tables created by Hudi > 0.10.X. However, in DeltaStreamer entrypoints, this configuration is not written to hoodie.properties, which will cause incorrect query results via Spark.

This PR fixes the aforementioned assumptions by ensuring that hoodie.datasource.write.hive_style_partitioning is written to hoodie.properties.

Impact

Describe any public API or user-facing feature change or any performance impact.

None

Risk level (write none, low medium or high below)

If medium or high, explain what verification was done to mitigate the risks.

Low

Documentation Update

Describe any necessary documentation update if there is any new feature, config, or user-facing change

• The config description must be updated if new configs are added or the default value of the configs are changed
• Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
  ticket number here and follow the instruction to make
  changes to the website.

Contributor's checklist

• Read through contributor's guide
• Change Logs and Impact were stated clearly
• Adequate tests were added if applicable
• CI passed

[voonhous]

@boneanxs for visibility

[boneanxs]

+1 for this

[voonhous]

Also, we may need add an improvement for how tables are initialised in the future so that all entrypoints will use a common HoodieTableMetaClient initialiser.

Instead of the current implementation where all entrypoints are dictating their own means of creating a HoodieTableMetaClient.

Once that is done, we will also need a configuration validation component to check the configs of a table.

[TengHuo]

According the the code in HoodieSparkSqlWriter, there are few more config when building HoodieTableConfig.

https://github.com/apache/hudi/blob/720c9d76c1d281b7a1305a205d195a4f179ce36a/hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieSparkSqlWriter.scala#LL203C13-L203C13

I think it's better we can align DeltaSync according to HoodieSparkSqlWriter.

BTW: totally agree, we should use a unique entrypoint for this HoodieTableConfig builder.

[voonhous]

According the the code in HoodieSparkSqlWriter, there are few more config when building HoodieTableConfig.

https://github.com/apache/hudi/blob/720c9d76c1d281b7a1305a205d195a4f179ce36a/hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieSparkSqlWriter.scala#LL203C13-L203C13

I think it's better we can align DeltaSync according to HoodieSparkSqlWriter.

BTW: totally agree, we should use a unique entrypoint for this HoodieTableConfig builder.

Missing configs that are in HoodieSparkSqlWriter.scala, but not in DeltaSync.java.

In initializeEmptyTable()

.setCommitTimezone()
.setDatabaseName()
.set(timestampKeyGeneratorConfigs)

In readFromSource()

.setCDCEnabled()
.setCDCSupplementalLoggingMode()
.setCommitTimezone()
.setDatabaseName()
.setPreCombineField()
.setRecordKeyFields()
.set(timestampKeyGeneratorConfigs)

[voonhous]

Apologies again.

Fixed the checkstyle violations and re-executed a mvn clean install on my end.

[voonhous]

@hudi-bot run azure

[hudi-bot]

CI report:

• 7762747 UNKNOWN
• f9b5f2d Azure: FAILURE Azure: SUCCESS

Bot commands

@hudi-bot supports the following commands:

• @hudi-bot run azure re-run the last Azure build