[HUDI-5520] Limit MDT deltacommits when data table has pending action#8772
Merged
xushiyan merged 2 commits intoapache:masterfrom May 21, 2023
Merged
[HUDI-5520] Limit MDT deltacommits when data table has pending action#8772xushiyan merged 2 commits intoapache:masterfrom
xushiyan merged 2 commits intoapache:masterfrom
Conversation
4 tasks
Collaborator
zhangyue19921010
approved these changes
May 21, 2023
Contributor
zhangyue19921010
left a comment
zhangyue19921010
left a comment
There was a problem hiding this comment.
LGTM. just a nit comment.
| if (numDeltaCommits > maxNumDeltaCommitsWhenPending) { | ||
| throw new HoodieMetadataException(String.format("Metadata table's deltacommits exceeded %d: " | ||
| + "this is likely caused by a pending instant in the data table. Resolve the pending instant " | ||
| + "or adjust `%s`, the restart the pipeline.", |
Contributor
There was a problem hiding this comment.
nit: the restart the pipeline. => then restart the pipeline
Member
Author
There was a problem hiding this comment.
thanks for pointing out. will fix and then land.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Logs
Prevent MDT deltacommits from growing infinitely when there is pending action in the data table.
New advanced config:
hoodie.metadata.max.deltacommits.when_pendingImpact
MDT compaction flow.
Risk level
Low.
Documentation Update
NA
Contributor's checklist