Skip to content

[DNM][Testing Only][HUDI-6276] Rename HoodieDeltaStreamer to HoodieStreamer#8827

Closed
yihua wants to merge 13 commits intoapache:masterfrom
yihua:HUDI-6276-rename-deltastreamer-no-test-changes
Closed

[DNM][Testing Only][HUDI-6276] Rename HoodieDeltaStreamer to HoodieStreamer#8827
yihua wants to merge 13 commits intoapache:masterfrom
yihua:HUDI-6276-rename-deltastreamer-no-test-changes

Conversation

@yihua
Copy link
Contributor

@yihua yihua commented May 27, 2023

Change Logs

Test the renaming with old HoodieDeltaStreamer class

Impact

N/A

Risk level

none

Documentation Update

N/A

Contributor's checklist

  • Read through contributor's guide
  • Change Logs and Impact were stated clearly
  • Adequate tests were added if applicable
  • CI passed

@nsivabalan nsivabalan added the priority:blocker Production down; release blocker label Jun 28, 2023
@codope
Copy link
Member

codope commented Jun 28, 2023

Wouldn't this be a breaking change? Are both the class names handled in code? Should we do this in 1.x?

@codope codope added priority:high Significant impact; potential bugs and removed priority:blocker Production down; release blocker labels Jun 28, 2023
@nsivabalan nsivabalan added priority:blocker Production down; release blocker and removed priority:high Significant impact; potential bugs labels Jul 5, 2023
@yihua yihua force-pushed the HUDI-6276-rename-deltastreamer-no-test-changes branch from 30096da to 6c7bcd1 Compare July 10, 2023 17:10
@yihua yihua changed the title [DNM][HUDI-6276] Rename HoodieDeltaStreamer to HoodieStreamer [DNM][Testing Only][HUDI-6276] Rename HoodieDeltaStreamer to HoodieStreamer Jul 10, 2023
@yihua yihua force-pushed the HUDI-6276-rename-deltastreamer-no-test-changes branch from 7f0cf39 to 4dff804 Compare July 10, 2023 23:27
@hudi-bot
Copy link
Collaborator

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

@yihua
Copy link
Contributor Author

yihua commented Jul 11, 2023

Wouldn't this be a breaking change? Are both the class names handled in code? Should we do this in 1.x?

Mentioned in #9168: the old naming still works so the change is backward compatible.

@yihua
Copy link
Contributor Author

yihua commented Jul 11, 2023

Closing this as it is test only.

@yihua yihua closed this Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority:blocker Production down; release blocker release-0.14.0

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

4 participants