[HUDI-6342] Fixing flaky Continuous mode multi writer tests#8910
Merged
danny0405 merged 1 commit intoapache:masterfrom Jun 9, 2023
Merged
[HUDI-6342] Fixing flaky Continuous mode multi writer tests#8910danny0405 merged 1 commit intoapache:masterfrom
danny0405 merged 1 commit intoapache:masterfrom
Conversation
nsivabalan
added
release-0.14.0
priority:critical
nsivabalan
commented
Jun 9, 2023
| if (expectConflict && backfillFailed.get() && e.getCause().getMessage().contains(ConcurrentModificationException.class.getName())) { | ||
| // expected ConcurrentModificationException since ingestion & backfill will have overlapping writes | ||
| if (backfillFailed.get()) { | ||
| if (!continuousFailed.get()) { |
Contributor
Author
There was a problem hiding this comment.
NTR: in most cases backfill job fails and hence the test succeeds. but if continuous job fails, the test times out.
Contributor
Author
|
we have an unrelated test failure (GH action failure) since this patch is also fixing a flaky test, prefer to go ahead w/ landing. we should probably triage and put a follow up patch on this flaky test. |
Collaborator
codope
approved these changes
Jun 9, 2023
| throw new HoodieException("Both backfilling and ingestion job failed ", e); | ||
| } | ||
| } else if (expectConflict && continuousFailed.get() && e.getCause().getMessage().contains("Ingestion service was shut down with exception")) { | ||
| // incase of regular ingestion job failing, ConcurrentModificationException is not throw all the way. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Logs
Fixing flaky Continuous mode multi writer tests. Exception thrown when continuous mode job fails is different than exception thrown while backfill job fails. So, had to fix the tests accounting for that.
Impact
Fixing flaky Continuous mode multi writer tests. Exception thrown when continuous mode job fails is different than exception thrown while backfill job fails. So, had to fix the tests accounting for that.
Risk level (write none, low medium or high below)
Stabilizes CI
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change
ticket number here and follow the instruction to make
changes to the website.
Contributor's checklist