[HUDI-6403] Ensure hoodie.properties updated after deleting MDT#9010
Merged
xushiyan merged 3 commits intoapache:masterfrom Jun 19, 2023
Merged
[HUDI-6403] Ensure hoodie.properties updated after deleting MDT#9010xushiyan merged 3 commits intoapache:masterfrom
hoodie.properties updated after deleting MDT#9010xushiyan merged 3 commits intoapache:masterfrom
Conversation
xushiyan
added
priority:critical
xushiyan
commented
Jun 18, 2023
...client/hudi-client-common/src/main/java/org/apache/hudi/client/utils/MetadataTableUtils.java
Show resolved
Hide resolved
codope
reviewed
Jun 18, 2023
Member
codope
left a comment
codope
left a comment
There was a problem hiding this comment.
Looks good to me, with a minor comment.
hudi-common/src/main/java/org/apache/hudi/metadata/MetadataTableUtils.java
Outdated
Show resolved
Hide resolved
xushiyan
commented
Jun 18, 2023
...ce/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/procedure/TestMetadataProcedure.scala
Show resolved
Hide resolved
Contributor
zhangyue19921010
left a comment
zhangyue19921010
left a comment
There was a problem hiding this comment.
Hi @xushiyan, I believe this is a bug in DeleteMetadataTableProcedure which just delete MDT folder.
On the other hand, when user disable MDT, we also try to delete existed MDT, mentioned in
… MDT" This reverts commit 60ee5f7.
xushiyan
commented
Jun 18, 2023
Member
Author
xushiyan
left a comment
xushiyan
left a comment
There was a problem hiding this comment.
@codope @zhangyue19921010 can you pls take another look? changed to use existing API for this
| try { | ||
| LOG.info("Deleting metadata table because it is disabled in writer."); | ||
| deleteMetadataTable(config.getBasePath(), context); | ||
| clearMetadataTablePartitionsConfig(Option.empty(), true); |
Member
Author
There was a problem hiding this comment.
removed this as the properties update is included in deleteMetadataTable()
Collaborator
codope
approved these changes
Jun 19, 2023
4 tasks
Contributor
|
All looks good to me. Thanks @xushiyan |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Logs
When deleting metadata table via fs.delete,
hoodie.propertiesmay still contain these 2 table configs, which should be removed as these configs are for readers to determine which metadata partitions can be usedhoodie.table.metadata.partitionshoodie.table.metadata.partitions.inflightMade sure applicable scenarios standardize the way to delete MDT via
HoodieTableMetadataUtil#deleteMetadataTableImpact
MDT deletion flow and subsequent read was impacted.
Risk level
Low
Documentation Update
NA
Contributor's checklist