[HUDI-6454] Remove redundant indexing testcases#9077
Merged
nsivabalan merged 1 commit intoapache:masterfrom Jun 28, 2023
Merged
[HUDI-6454] Remove redundant indexing testcases#9077nsivabalan merged 1 commit intoapache:masterfrom
nsivabalan merged 1 commit intoapache:masterfrom
Conversation
xushiyan
commented
Jun 28, 2023
| * @param config instance of {@link HoodieWriteConfig} to use | ||
| * @param writeFn write function to be used for testing | ||
| */ | ||
| private void testUpsertsUpdatePartitionPath(IndexType indexType, HoodieWriteConfig config, |
Member
Author
There was a problem hiding this comment.
Covered in TestGlobalIndexEnableUpdatePartitions
Comment on lines
105
to
+111
| {IndexType.SIMPLE, true, true}, | ||
| {IndexType.SIMPLE, true, false}, | ||
| {IndexType.SIMPLE, false, true}, | ||
| {IndexType.SIMPLE, false, false}, | ||
| {IndexType.GLOBAL_SIMPLE, true, true}, | ||
| {IndexType.GLOBAL_SIMPLE, true, false}, | ||
| {IndexType.GLOBAL_SIMPLE, false, true}, | ||
| {IndexType.GLOBAL_SIMPLE, false, false}, | ||
| {IndexType.BUCKET, false, true}, | ||
| {IndexType.BUCKET, true, false}, | ||
| {IndexType.BUCKET, false, false}, | ||
| {IndexType.RECORD_INDEX, true, true}, | ||
| {IndexType.RECORD_INDEX, true, false} | ||
| {IndexType.RECORD_INDEX, true, true} |
Member
Author
There was a problem hiding this comment.
- popluateMetaFields (true/false) only applies to bucket index.
- only test record index when MDT enabled
|
|
||
| @ParameterizedTest | ||
| @MethodSource("indexTypeParams") | ||
| public void testSimpleTagLocationAndUpdateWithRollback(IndexType indexType, boolean populateMetaFields, boolean enableMetadataIndex) throws Exception { |
Member
Author
There was a problem hiding this comment.
merged into testSimpleTagLocationAndUpdate
|
|
||
| @ParameterizedTest | ||
| @EnumSource(value = IndexType.class, names = {"GLOBAL_BLOOM", "GLOBAL_SIMPLE"}) | ||
| public void testSimpleGlobalIndexTagLocationWhenShouldUpdatePartitionPath(IndexType indexType) throws Exception { |
Member
Author
There was a problem hiding this comment.
Covered in TestGlobalIndexEnableUpdatePartitions
|
|
||
| @ParameterizedTest | ||
| @ValueSource(booleans = {true}) | ||
| public void testRecordIndexTagLocationAndUpdate(boolean populateMetaFields) throws Exception { |
Member
Author
There was a problem hiding this comment.
covered in parameterized testSimpleTagLocationAndUpdate
| } | ||
|
|
||
| @Test | ||
| public void testTagLocationWhenShouldUpdatePartitionPath() throws Exception { |
Member
Author
There was a problem hiding this comment.
Covered in TestGlobalIndexEnableUpdatePartitions
xushiyan
added
priority:critical
Collaborator
nsivabalan
approved these changes
Jun 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Logs
Remove redundant/repeated testcases to reduce CI runtime.
Impact
Indexing test coverage
Risk level
Low.
Documentation Update
NA
Contributor's checklist