[MINOR] Improve CollectionUtils helper methods#9088
Merged
xushiyan merged 1 commit intoapache:masterfrom Jun 29, 2023
Merged
Conversation
xushiyan
commented
Jun 29, 2023
Comment on lines
-247
to
-249
| public static <T> Set<T> createSet(final T... elements) { | ||
| return Stream.of(elements).collect(Collectors.toSet()); | ||
| } |
Comment on lines
-251
to
-253
| public static <K,V> Map<K, V> createImmutableMap(final K key, final V value) { | ||
| return Collections.unmodifiableMap(Collections.singletonMap(key, value)); | ||
| } |
Member
Author
There was a problem hiding this comment.
removed. use singletonMap() instead. this overloading interferes with createImmutableMap(final Pair<K, V>... elements when there are 2 Pairs
Comment on lines
-260
to
-261
| public static <K,V> Map<K,V> createImmutableMap(final Map<K,V> map) { | ||
| return Collections.unmodifiableMap(map); |
Comment on lines
-274
to
-279
| public static <K,V> HashMap<K, V> createHashMap(final Pair<K, V>... elements) { | ||
| HashMap<K,V> map = new HashMap<>(); | ||
| for (Pair<K,V> pair: elements) { | ||
| map.put(pair.getLeft(), pair.getRight()); | ||
| } | ||
| return map; |
codope
approved these changes
Jun 29, 2023
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Logs
Remove
createImmutableMap(final K key, final V value), which interferes with overloaded methodcreateImmutableMap(final Pair<K,V>... elements). UseCollections.singletonMap()instead.Impact
Core utils.
Risk level
Low.
Documentation Update
NA
Contributor's checklist