Skip to content

[MINOR] Enable log compaction by default for MDT#9092

Closed
codope wants to merge 2 commits intoapache:masterfrom
codope:mdt-log-compaction
Closed

[MINOR] Enable log compaction by default for MDT#9092
codope wants to merge 2 commits intoapache:masterfrom
codope:mdt-log-compaction

Conversation

@codope
Copy link
Member

@codope codope commented Jun 29, 2023

Change Logs

Enable log compaction on metadata table by default.

Impact

Will compact log blocks to produce another log file every 5 log blocks.

Risk level (write none, low medium or high below)

medium

Documentation Update

Describe any necessary documentation update if there is any new feature, config, or user-facing change

  • The config description must be updated if new configs are added or the default value of the configs are changed
  • Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
    ticket number here and follow the instruction to make
    changes to the website.

Contributor's checklist

  • Read through contributor's guide
  • Change Logs and Impact were stated clearly
  • Adequate tests were added if applicable
  • CI passed

@codope codope marked this pull request as draft June 29, 2023 12:14
Copy link
Contributor

@danny0405 danny0405 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-1 for the moment, let's not do this without enough production validations.

@codope codope force-pushed the mdt-log-compaction branch from 408e9f9 to c1b4e49 Compare July 5, 2023 08:35
@codope
Copy link
Member Author

codope commented Jul 5, 2023

Sure. That's why kept it in draft. Just wanted to check with this PR what all tests are failing.

@hudi-bot
Copy link
Collaborator

hudi-bot commented Jul 5, 2023

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

@codope codope closed this Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants