[HUDI-6521] Disable failing test case.#9169
Merged
nsivabalan merged 4 commits intoapache:masterfrom Jul 11, 2023
Merged
Conversation
4 tasks
nsivabalan
reviewed
Jul 11, 2023
| } | ||
| } | ||
| } | ||
| // FAILING TEST CASE. DO NOT UNCOMMENT BEFORE FIXING THE TEST CASE (see https://github.com/apache/hudi/pull/9156) |
Contributor
There was a problem hiding this comment.
This is now how we disable tests. we use "Disabled" tag to disable tests. we need to add a hudi jira adding links to failures and stacktraces may be and then add jira no in the Disabled annotation. you can find examples in our test suite.
Contributor
Author
There was a problem hiding this comment.
Fixed using following syntax/structure
/** Ignore failing test case (see HUDI-6521 for more details) */
ignore("Test Bulk Insert Into Bucket Index Table") {
...
}
amrishlal
changed the title
amrishlal
changed the title
nsivabalan
approved these changes
Jul 11, 2023
Collaborator
Contributor
Author
|
@hudi-bot run azure |
Contributor
|
Hi @amrishlal and @nsivabalan, sorry for the test case failure introduced. I have raised #9163 and fixed ci. Should we just revert this pr and enable the test again? Thanks~ |
stream2000
added a commit
to stream2000/hudi
that referenced
this pull request
Jul 13, 2023
This reverts commit 51ddf1a.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Logs
The test case
Test Bulk Insert Into Bucket Index TableinTestInsertTable.scalais failing as a result of changes made in ##9156. Commenting out the test case to unblock to the build.Impact
None
Risk level (write none, low medium or high below)
None
Documentation Update
None
Contributor's checklist