Fix parquet bloom filters impl and tests#9245
Merged
danny0405 merged 1 commit intoapache:masterfrom Jul 21, 2023
Merged
Conversation
Contributor
Author
|
@danny0405 may you take a look on this ? Thanks ! |
danny0405
approved these changes
Jul 21, 2023
|
hi @danny0405 @parisni , when would this feature be released? Thanks & Regards, |
Contributor
Author
|
@gsudhanshu from the jira tracker this should be in upcoming 0.14 version. https://issues.apache.org/jira/browse/HUDI-6226 But I couldn't find the commit in the release. Not sure then |
|
@parisni can you kindly escalate this and ensure that this commit comes in 0.14 v release we need it, thanks |
Contributor
Author
|
OK let me drive this
…On September 22, 2023 11:18:49 AM UTC, gsudhanshu ***@***.***> wrote:
@parisni can you kindly escalate this and ensure that this commit comes in 0.14 v release
we need it, thanks
--
Reply to this email directly or view it on GitHub:
#9245 (comment)
You are receiving this because you were mentioned.
Message ID: ***@***.***>
|
Contributor
Author
|
Hi, the parquet bloom filter will be available in the 0.14.x release
see
https://github.com/apache/hudi/blob/release-0.14.0-rc3/hudi-common/src/main/java/org/apache/hudi/io/storage/HoodieBaseParquetWriter.java#L78
…On Fri, 2023-09-22 at 04:18 -0700, gsudhanshu wrote:
@parisni can you kindly escalate this and ensure that this commit
comes in 0.14 v release
we need it, thanks
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Logs
This makes the parquet bloom filter work correctly. After trying out the #8716 the bloom where not being created
This PR :
Double check with parquet-cli after the patch confirmed the bloom exist. We cannot yet use such checks since only recent version of parquet can verify the bloom exist
Impact
Describe any public API or user-facing feature change or any performance impact.
Risk level (write none, low medium or high below)
If medium or high, explain what verification was done to mitigate the risks.
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change
ticket number here and follow the instruction to make
changes to the website.
Contributor's checklist