[MINOR] Add rowId field to HoodieRecordIndexInfo in metadata payload#9286
[MINOR] Add rowId field to HoodieRecordIndexInfo in metadata payload#9286codope wants to merge 3 commits intoapache:masterfrom
Conversation
|
Can we introduce it when the rowId really got used if the addition of a long field is backwards compatible? |
|
@danny0405 We will probably be using rowId in this release itself for positional deletes. cc @yihua |
minor cleanup
|
@codope, could rowId field add to metadata column? |
The intention behind adding this to metadata table was to efficiently locate offset within a page. If we add as a meta column, we still need to add it to separately to metadata table. Any particular reason or usecase you think where this field as a meta column would be useful? |
|
@codope, append mode deduplication may use this field. |
danny0405
left a comment
There was a problem hiding this comment.
We might need to think through before we move into this direction.
Change Logs
Add
rowIdlong field to HoodieRecordIndexInfo in metadata payload. The rowId is not being read/written right now. Default is 0L. In future, we would want to map a record to file and rowId (to indicate offset within a page in column chunk) in record index, then this field would be useful.Impact
None. Just an addition of a long field which should be backwards compatible.
Risk level (write none, low medium or high below)
none
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change
ticket number here and follow the instruction to make
changes to the website.
Contributor's checklist