[HUDI-6594] Support duplicate with HFile Reader/Writer#9292
Closed
codope wants to merge 4 commits intoapache:masterfrom
Closed
[HUDI-6594] Support duplicate with HFile Reader/Writer#9292codope wants to merge 4 commits intoapache:masterfrom
codope wants to merge 4 commits intoapache:masterfrom
Conversation
codope
commented
Jul 26, 2023
|
|
||
| protected abstract Map<String, HoodieRecord<HoodieMetadataPayload>> getRecordsByKeys(List<String> keys, String partitionName); | ||
|
|
||
| protected abstract Map<String, List<HoodieRecord<HoodieMetadataPayload>>> getAllRecordsByKeys(List<String> keys, String partitionName); |
Member
Author
There was a problem hiding this comment.
@nsivabalan I added a separate method (yet to fully implement) for separation as we will have duplicates only in case of RLI for now. But, should we chnage the return type existing getRecordsByKeys?
codope
commented
Jul 26, 2023
| .map(key -> (HoodieRecord<HoodieMetadataPayload>) allRecords.get(key)) | ||
| .filter(Objects::nonNull) | ||
| .collect(Collectors.toMap(HoodieRecord::getRecordKey, r -> r)); | ||
| .collect(Collectors.toMap(HoodieRecord::getRecordKey, r -> r, (r1, r2) -> r2)); |
Member
Author
There was a problem hiding this comment.
this will be reverted after the new BaseTableMetadata#getAllRecordsByKeys is implemented.
Collaborator
Contributor
|
guess we don't need this anymore. feel free to re-open or create a new one if need be |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Logs
Support duplicate with HFile Reader/Writer and MDT record index.
HoodieAvroHFileReader#getRecordByKeyIteratorInternalto return anIterator<IndexedRecord>for given keys.HoodieTableMetadataAPI changes - new method that returns a list of HoodieRecords:Impact
MDT can have duplcates. Useful for record index to work as regular non-global index.
Risk level (write none, low medium or high below)
medium
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change
ticket number here and follow the instruction to make
changes to the website.
Contributor's checklist