[MINOR] Expose filename when getting commit time from illegal filename#9304
Merged
yihua merged 3 commits intoapache:masterfrom Jul 28, 2023
Merged
[MINOR] Expose filename when getting commit time from illegal filename#9304yihua merged 3 commits intoapache:masterfrom
yihua merged 3 commits intoapache:masterfrom
Conversation
Contributor
How could this happen? |
Contributor
Author
|
Hi @danny0405 , this would happen when some users accidently copy files to their table location or writer is not correctly set up like they forgot to use |
danny0405
reviewed
Jul 28, 2023
hudi-common/src/main/java/org/apache/hudi/common/fs/FSUtils.java
Outdated
Show resolved
Hide resolved
danny0405
approved these changes
Jul 28, 2023
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Logs
Sometimes users can get non-hudi files mixed in Hudi table causing
ArrayIndexOutOfBoundsExceptionwhen getting commit time from filename. This fix is to expose this error better to make it easier for users to identify problematic files.Impact
None
Risk level (write none, low medium or high below)
None
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change
ticket number here and follow the instruction to make
changes to the website.
Contributor's checklist