[MINOR] fix update metric not be updated#9316
Merged
danny0405 merged 1 commit intoapache:masterfrom Jul 31, 2023
Merged
Conversation
Collaborator
danny0405
reviewed
Jul 31, 2023
| return false; | ||
| } | ||
| updatedRecordsWritten++; | ||
| } |
Contributor
There was a problem hiding this comment.
A valid fix, probably the code is copied from a legacy error logic.
danny0405
approved these changes
Jul 31, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Logs
will not update updateNumber metric when record not be update
Impact
low
In the following method, updateNumber is determined by tagLocation, will not compare update or not. After this pr, it's may be different in these two.
In the following method, it will save to infight file, which I found is used to rollback failed commit, but not use the updateNumber metric, and insertNumber metric is not used too, so I think the two metric in infight file is not work, maybe I missed any key information, let me know
hudi/hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/commit/BaseCommitActionExecutor.java
Line 120 in 64310f5
Risk level (write none, low medium or high below)
low
Documentation Update
None
Contributor's checklist