[HUDI-2141] Support flink read metrics#9350
Merged
danny0405 merged 2 commits intoapache:masterfrom Aug 4, 2023
Merged
Conversation
Contributor
Author
|
@danny0405 Could you help review this pr？ |
stream2000
changed the title
danny0405
reviewed
Aug 3, 2023
| this.instantState.add(this.issuedInstant); | ||
| this.readMetrics.setIssuedInstant(this.issuedInstant); | ||
| } | ||
| if (this.issuedOffset != null) { |
Contributor
There was a problem hiding this comment.
Does the metrics got updated for each read?
Contributor
Author
There was a problem hiding this comment.
The metrics will be updated for each checkpoint
danny0405
reviewed
Aug 3, 2023
| } | ||
|
|
||
| readMetrics.setSplitLatestCommit(split.getLatestCommit()); | ||
|
|
Contributor
There was a problem hiding this comment.
Does the metrics got updated for each read?
Contributor
Author
There was a problem hiding this comment.
The metrics will be updated for every new split.
Contributor
There was a problem hiding this comment.
Maybe we should move it to line 170.
stream2000
force-pushed
the
HUDI-2141_flink_read_metrics
branch
from
f36281c to
0341a4d
Compare
Contributor
Author
|
@danny0405 Comments added~PTAL |
danny0405
reviewed
Aug 3, 2023
| import java.time.Instant; | ||
|
|
||
| /** | ||
| * Metrics for flink stream read |
Contributor
There was a problem hiding this comment.
Every comment should end up with dot ..
Contributor
Author
|
@danny0405 Thanks for your review, all comments addressed~ |
Collaborator
danny0405
approved these changes
Aug 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Logs
Subtask for HUDI-2141, support flink read metrics
stream write metrics and compaction metrics see #9118
Impact
add some metrics
Risk level (write none, low medium or high below)
none
Documentation Update
Will update document after merge
Contributor's checklist